-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF, BRK] Decision tree modularization #476
[REF, BRK] Decision tree modularization #476
Conversation
… into feature/pytest_skip_integration
This reverts commit 769f4b7.
… into feature/pytest_skip_integration
Starting to connect metric modularization to decision tree modularization
list should be used as a short-hand for common trees. | ||
""" | ||
|
||
fname = resource_filename('tedana', 'selection/data/{}.json'.format(tree)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to optionally support full paths here, so people can feed in their own trees with a full file path or they can call our built-in trees with just the name of the tree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added support for full paths (and changed the error messages accordingly)
There are a lot of merge conflicts that will need to be address. Also, if you remove the pytest_cache files and revert changes to |
+1, here. I'm not planning to review this until #475 is merged so the diff is minimized -- hopefully that, removing the cache files, and reverting tedica changes should make this easier ! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions to tedana:tada: ! |
Not stale. Paused until #475 is reviewed & ready to integrate with this PR. |
This issue has been automatically marked as stale because it has not had any activity in 90 days. It will be closed in 600 days if no further activity occurs. Thank you for your contributions to tedana:tada: ! |
I don't know how/why I closed this. For some reason it won't let me reopen it though... |
It says the |
oh thank goodness. phew! |
Closes #403 .
Changes proposed in this pull request:
-Most functions that define each decision tree step are in selection_nodes.py
-There are some minor changes in decision tree steps that might result in breaking the existing tests
Known issues: